feat(UI): add label apis#1144
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds first-class support for labels across the stack—database, backend API, generated TypeScript types, and UI—replacing the old owner field with user_id.
- Introduces new
labelanditem_labelstables via a SeaORM migration and extends theconv_type_enum. - Extends Axum routers, handlers, and storage to create, list, and update labels on issues and merge requests.
- Updates generated TypeScript definitions (
LabelItem, payloads, API methods) and adapts React components to useuser_idand display labels.
Reviewed Changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| third-party/Cargo.toml | Bump tokio-tungstenite/tungstenite to 0.27 for new API needs |
| moon/packages/types/generated.ts | Add LabelItem, label-related payloads and methods |
| moon/apps/web/components/Issues/IssuesContent.tsx | Switch from owner to user_id |
| moon/apps/web/components/Issues/IssuePage.tsx | Switch from owner to user_id |
| mono/src/server/https_server.rs | Allow PUT in CORS and register LABEL_TAG |
| mono/src/api/user/user_router.rs | Simplify SSH key/token handlers with ? |
| mono/src/api/oauth/mod.rs | Replace unwrap() with error logging and ? |
| mono/src/api/oauth/campsite_store.rs | Simplify JSON deserialization error handling |
| mono/src/api/mr/mr_router.rs | Refactor MR handlers; add /api/v1/mr/labels route |
| mono/src/api/label/mod.rs | Define LabelItem & NewLabel models |
| mono/src/api/label/label_router.rs | Add /label/new and /label/list Axum routes |
| mono/src/api/issue/mod.rs | Extend IssueItem, IssueDetail, and add label payload |
| mono/src/api/issue/issue_router.rs | Add /issue/labels route and shared label logic |
| mono/src/api/error.rs | Return JSON CommonResult on errors |
| mono/src/api/api_router.rs | Merge in label_router |
| jupiter/migration/src/m20250618_065050_add_label.rs | Create label/item_labels tables and drop old owner column |
| jupiter/src/storage/issue_storage.rs | Extend storage with label CRUD & conversation logging |
| jupiter/src/storage/mr_storage.rs | Remove legacy MR conversation methods |
| jupiter/callisto/src/sea_orm_active_enums.rs | Add Label variant to ConvTypeEnum |
| jupiter/callisto/src/mega_issue.rs | Remove owner, add user_id |
| jupiter/callisto/src/label.rs | Generate SeaORM entity for label |
| jupiter/callisto/src/item_labels.rs | Generate SeaORM entity for item_labels |
| config/config.toml | Update campsite_api_domain and allowed CORS origins |
| common/src/model.rs | Add common_failed() helper |
| common/src/errors.rs | Derive thiserror::Error on MegaError |
| ceres/src/protocol/mod.rs | Remove deprecated mr protocol |
| ceres/src/pack/monorepo.rs | Switch to mega_mr::Model and propagate MegaError |
| ceres/src/api_service/mono_api_service.rs | Switch merge/MR API to use mega_mr::Model |
Comments suppressed due to low confidence (1)
common/src/errors.rs:13
- The
Errorderive macro is used but not imported; adduse thiserror::Error;at the top to avoid a compile error.
#[derive(Error, Debug)]
Comment on lines
+81
to
+82
| .await | ||
| .unwrap(); |
There was a problem hiding this comment.
Using .unwrap() here can panic the server if adding a conversation fails; replace with ? to propagate the error instead of unwrapping.
| let old_labels = issue_storage | ||
| .find_item_exist_labels(payload.item_id) | ||
| .await | ||
| .unwrap(); |
There was a problem hiding this comment.
Calling .unwrap() on the result of find_item_exist_labels may cause a panic; use ? to return an error if label‐lookup fails.
Suggested change
| .unwrap(); | |
| ?; |
genedna
enabled auto-merge
June 20, 2025 14:35
genedna
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.